-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(component): add less support #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{ name: 'verbose', type: Boolean, default: false, aliases: ['v'] }, | ||
{ name: 'blueprint', type: String, default: 'ng2', aliases: ['b'] }, | ||
{ name: 'name', type: String, default: '', aliases: ['n'] }, | ||
{ name: 'style', type: String, default: 'css', aliases: ['s'] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need a test for this
Thanks @wesleycho, I liked the approach. |
Alright, I'll take a look today at writing the tests - might not get to it for a few days. The approach is a bit hackish since it rewrites the file name after install, but I couldn't think of anything better. |
Yes, we might have template files in the future, but I'm ok with this for now. |
9e5e686
to
01b4c48
Compare
I added tests, still need to implement that change to only compile the less if less is present, pending answer to question. |
- Add optional support for less via `style` option
01b4c48
to
26c27c2
Compare
There was been talk of a |
Also, there seems to be some trouble with newly generates files #120 (comment) |
As of now the idea of configuration has been moved into |
just wondering how this is optional support (as I'd like to have SASS instead) :) |
This feels like something that we should support properly but need design beforehand. We need to let the user choose, and I think I'm reworking the specs of I think this PR should be closed as this will never be something we support natively. There should not be a force of technology that the user has to pick (outside of the cli itself, of course). I could even see a point where we don't force the user to use TypeScript if he doesn't want to, and generate JavaScript components. I had a |
I'm in agreement - even my refactor I have locally still is a bit incorrect. This probably needs a whole spec and maybe a plugin implementation. |
Wes, you'll be in on the discussion for the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
style
option