Skip to content

osx travis config and basic e2e test suite #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

osx travis config and basic e2e test suite #133

wants to merge 1 commit into from

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented Jan 3, 2016

There was a problem as travis osx configuration did not find nvm. Fixed now.
Related issue: #91.
It also applies on basic e2e test suite issue #90

@jkuri jkuri mentioned this pull request Jan 3, 2016
@jkuri jkuri changed the title Added OSX Travis configuration osx travis config and basic e2e test suite Jan 4, 2016
@filipesilva
Copy link
Contributor

Looks good to me!

Both this PR and #128 seem to address #91, but this one is more complete I think. We can then extend the basic e2e to include more scenarios.

@filipesilva
Copy link
Contributor

Could you rebase on master?

@cironunes
Copy link
Member

Can you add two separated commits? One for Travis setup and the other with the basic e2e test suite stuff?

@jkuri
Copy link
Contributor Author

jkuri commented Jan 24, 2016

Sure, I'll rebase and make separated commits.

@cironunes
Copy link
Member

@jkuri please let me know if you need any help, we can share screens to get it done

@jkuri
Copy link
Contributor Author

jkuri commented Jan 25, 2016

@cironunes thanks, sure I will let you know, right now I am writing tests for #135. My skype name is recoil_x btw.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants