Skip to content

Turn on osx build on travis #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Turn on osx build on travis #128

wants to merge 2 commits into from

Conversation

cthrax
Copy link

@cthrax cthrax commented Dec 28, 2015

This should address #91 . Basically just needed to make sure nvm was installed before proceeding, might be other differences in the future, but for now all tests pass with just that.

@cironunes
Copy link
Member

Awesome! Thanks a lot @cthrax. Could you squash all the commits and fix the message?

@cthrax
Copy link
Author

cthrax commented Dec 28, 2015

I think that should do it, I had to do a --force push due to all the previous pushes, but that shouldn't effect the pull request I think.

@filipesilva
Copy link
Contributor

I think #133 has fixed this issue, so I'm closing it.

If that isn't the case feel free to reopen.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants