Skip to content

feat: pin down all direct dependencies #12185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

feat: pin down all direct dependencies #12185

merged 1 commit into from
Sep 7, 2018

Conversation

alan-agius4
Copy link
Collaborator

This is so that CLI users get the same direct dependency versions that were tested on the CI.

@alan-agius4 alan-agius4 requested a review from clydin September 6, 2018 10:11
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 6, 2018
@ngbot
Copy link

ngbot bot commented Sep 6, 2018

Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Sep 6, 2018

Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 6, 2018
@alan-agius4
refactor: pin down all direct dependencies
8e00420 
This is so that CLI users get the same direct dependency versions that were tested on the CI.
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@filipesilva filipesilva added target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release cla: yes labels Sep 7, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@clydin clydin removed the cla: yes label Sep 7, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@clydin clydin mentioned this pull request Sep 7, 2018
Closed
@kyliau kyliau merged commit b8b36ba into angular:master Sep 7, 2018
@alan-agius4 alan-agius4 deleted the feature_lock_everything branch September 7, 2018 18:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alan-agius4 @googlebot @filipesilva @clydin @kyliau