-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular-devkit/build-angular): update webpack dependencies #12038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -7778,13 +7878,20 @@ webpack-sources@^1.0.1, webpack-sources@^1.1.0: | |||
source-list-map "^2.0.0" | |||
source-map "~0.6.1" | |||
|
|||
webpack-sources@^1.2.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this should improve the CI build as well. As people are claiming good improvements on webpack when having sourcemaps enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to benchmark it the before and after with #12022. Only after the CI error is addressed though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CI error seems legit:
✗ supports lazy bundle for lazy routes with JIT (6 secs)
- Failed: No module factory available for dependency type: ContextElementDependency
|
1df1945
to
d3152bc
Compare
d3152bc
to
80f0cdf
Compare
2bf2a11
to
8056a0a
Compare
Covered by #12185 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.