Skip to content

feat(@angular-devkit/build-angular): update webpack dependencies #12038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 29, 2018

No description provided.

@@ -7778,13 +7878,20 @@ webpack-sources@^1.0.1, webpack-sources@^1.1.0:
source-list-map "^2.0.0"
source-map "~0.6.1"

webpack-sources@^1.2.0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should improve the CI build as well. As people are claiming good improvements on webpack when having sourcemaps enabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to benchmark it the before and after with #12022. Only after the CI error is addressed though.

alan-agius4
alan-agius4 previously approved these changes Aug 29, 2018
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 29, 2018
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CI error seems legit:

    ✗ supports lazy bundle for lazy routes with JIT (6 secs)
      - Failed: No module factory available for dependency type: ContextElementDependency

filipesilva
filipesilva previously approved these changes Sep 4, 2018
@clydin clydin removed the cla: yes label Sep 4, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@ralshammrei2
Copy link

#12038

filipesilva
filipesilva previously approved these changes Sep 6, 2018
@clydin clydin force-pushed the update-webpack branch 2 times, most recently from 2bf2a11 to 8056a0a Compare September 7, 2018 14:30
@clydin
Copy link
Member Author

clydin commented Sep 7, 2018

Covered by #12185

@clydin clydin closed this Sep 7, 2018
@clydin clydin deleted the update-webpack branch September 7, 2018 17:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants