Fix stuff

[gkalpak]

The main fix is:

• fix(@ schematics/angular): allow ServiceWorker to work with baseHref
  (Fixes ServiceWorker register generated by cli with base-href don't works #8515.)

This is a port of angular/devkit#999 from the archived devkit repo (minus the stuff already fixed in #11131).
The NGSW parts have been approved by @alxhub here.

[clydin]

What about a quick loop instead of the regex (plus tab support):

let indent = '';
for (const char of text) {
    if (char === ' ' || char === '\u0009') {
        indent += char;
    } else {
        break;
    }
}

[gkalpak]

I personally like RegExps, but happy to change it to whatever you prefer (or even keep the original version).
I just happened to go through the files trying to fix something else and made some changes that made sense to me (and hopefully to others).

[clydin]

I'm partial to the more self explanatory nature of the loop above then the other two options. And it definitely performs better than the first.

[gkalpak]

To each his own 😛
Happy to change it to a for loop.

[clydin]

Adding this to the actual template index.html may make sense since it applies to a standard web applications as well. Thoughts?

[gkalpak]

True. I guess this was added as poart of @angular/pwa, because good PWA practices include having fallback content for when JS is disabled, but this is indeed useful for non-PWA apps as well.
Should Imove it to index.html?

[clydin]

I think it eventually should but probably should be left to a separate PR. However, the addition here would need to stay either way to support projects that didn't get created with the new index.html. The code here should be augment now though to check if the noscriptelement is already present and only add if not. Since someone could have added the element manually as well.

[gkalpak]

Actually, I just realized that a proper solution should also check whether link[rel="manifest"] and meta[name="theme-color"] already exist as well. Since this PR is only refactoring that part of the code (no behavior changes), I'd rather leave the checks for another PR.

[clydin]

Good point and works for me.

[clydin]

@gkalpak looks like there was a rebase error with the last commit. Its message is fixup! refactor(@angular/pwa):...

[gkalpak]

It was intentional (to make it easier to review the changes). It is a "fixup" commit.
The merge scripts in angular/angular support them, but I guess angular/angular-cli has a different process. I'll squash the commits.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}