refactor: Consolidate adding dependencies #11131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
hansl
reviewed
Jun 8, 2018
| @@ -350,6 +345,6 @@ export default function (options: ApplicationOptions): Rule { | |||
| move(sourceDir), | |||
| ]), MergeStrategy.Overwrite), | |||
| schematic('e2e', e2eOptions), | |||
| ]); | |||
| ])(host, context); | |||
hansl
reviewed
Jun 8, 2018
| @@ -257,6 +255,6 @@ export default function (options: LibraryOptions): Rule { | |||
| context.addTask(new NodePackageInstallTask()); | |||
| } | |||
| }, | |||
| ]); | |||
| ])(host, context); | |||
hansl
reviewed
Jun 8, 2018
| node: JsonAstObject, | ||
| propertyName: string, | ||
| value: JsonValue, | ||
| indent = 4, |
There was a problem hiding this comment.
Indent is defaulted to 4, because the typical use case is to add a value to an existing object (i.e. dependencies, devDependencies) It could be removed as a default to make it more explicit.
hansl
reviewed
Jun 8, 2018
| import { UnitTestTree } from '@angular-devkit/schematics/testing'; | ||
| import { insertPropertyInAstObjectInOrder } from './json-utils'; | ||
|
|
||
| type Pojo = { |
hansl
reviewed
Jun 8, 2018
| return JSON.parse(tree.readContent(filePath)); | ||
| } | ||
|
|
||
| it('should insert a first prop', () => { |
There was a problem hiding this comment.
You should have a test where you call insertProperty... multiple times in a row.
filipesilva
approved these changes
Jun 8, 2018
Merged
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.