Skip to content

chore: implicityAny by default and update blueprints #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cironunes
Copy link
Member

Closes #107

@cironunes cironunes force-pushed the implicityAny branch 3 times, most recently from ddd1f0e to 8520a17 Compare December 16, 2015 12:56
@filipesilva
Copy link
Contributor

I think you forgot to change tsconfig.json to have "noImplicitAny": true,.

Other than that, it looks good.

@Brocco
Copy link
Contributor

Brocco commented Jan 23, 2016

@filipesilva We don't want to enable noImplicityAny, only have the blueprints support it being turned on without causing any issue. If we were to turn it on then it would force anyone using the CLI to write code to comply with that setting, which is something we don't want to do.

@filipesilva
Copy link
Contributor

Got it. Then this one looks ready to merge for me.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@hansl
Copy link
Contributor

hansl commented Jan 24, 2016

In order to close #107, we need to consider having noImplicitAny for our e2e tests. It seems like you're not enabling it anywhere (might have missed it).

@cironunes
Copy link
Member Author

@hansl this is just updating the blueprints, we can address having the config for our e2e tests in a separated PR. BTW, closing this in favor of #150

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consider turning on noImplicitAny by default
5 participants