This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Closes #62 and possibly #47 #65
Merged
+166
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses exact match of palceholder class attribute. That's to handle the case that the placeholder class equals the sortable's items class.
| // exact match with the placeholder's class attribute to handle | ||
| // the case that multiple connected sortables exist and | ||
| // the placehoilder option equals the class of sortable items | ||
| var excludes = element.find('[class="' + placeholder.element().attr('class') + '"]'); |
There was a problem hiding this comment.
This seems safer because it uses the class= search instead of a normal class search. That should fix the placeholder problems.
|
I like you're pull request better than mine and vote we merge yours in. I'm closing mine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62 and possibly #47.
Conflicts with #63.
example pen