Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Error with connected sortables and placeholders (angular1.2). #62

Closed
thgreasi opened this issue Nov 24, 2013 · 7 comments
Closed

Error with connected sortables and placeholders (angular1.2). #62

thgreasi opened this issue Nov 24, 2013 · 7 comments

Comments

@thgreasi
Copy link
Contributor

Here is a demo pen.
Just move an item back and forth to the other list.

@CyborgMaster
Copy link

So... I thought I would just play around with the pen and see if I could get things working, and I didn't realize that modifying it auto saves, so I think I may have broken your pen. Did I really break it for everyone, or is there a way to get back the original?

@CyborgMaster
Copy link

So I think I just figured out how to revert things, now I'm going to see if I can fix the problem.

@CyborgMaster
Copy link

Interesting bug. The reason it was breaking is the placeholder you had set up in this example had the same class as the elements in the list. Therefore as it was trying to remove the placeholder from the saved nodes list, it was removing the entire list. This wouldn't happen if the placeholder class was different then the class for the elements of the list.

I added a quick filter on the ng-scope class that angular adds to all the elements which fixes it and added a pull request.

@thgreasi
Copy link
Contributor Author

Sorry didn't saw that. Juster wanted to try the code from issue #47 for regressions.

@thgreasi
Copy link
Contributor Author

Can you also review PR #60?

@CyborgMaster
Copy link

@thgreasi I'm reviewing #60 and #65 now.

thgreasi added a commit that referenced this issue Dec 2, 2013
@thgreasi
Copy link
Contributor Author

thgreasi commented Dec 2, 2013

Fixed by #65.

@thgreasi thgreasi closed this as completed Dec 2, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants