This repository was archived by the owner on Sep 8, 2020. It is now read-only.
ui-select2 set dirty flag after initialization when simple_tags mode is on #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
In my project I use simple_tags option. But after the form containing select2 control is loaded, $pristine flag of select2 control and parent form is set to false and $dirty flag is set to true, which seems to be not correct. Here is plnkr for the issue: http://plnkr.co/edit/TjUscmd0vrMzEqOBURTe?p=preview. I found the way to fix it but I would like someone to review my changes and maybe give me advice how to do it better.
Thanks