Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Keep pristine state when attached to input tag #133

Merged
merged 1 commit into from
Jan 28, 2014
Merged

Keep pristine state when attached to input tag #133

merged 1 commit into from
Jan 28, 2014

Conversation

dmitry-dedukhin
Copy link
Contributor

This fiddle illustrates the problem.
This fiddle shows fixed version.

@dmitry-dedukhin
Copy link
Contributor Author

Oops, I've just found another pull request fixing the same issue but in a bit different way #66
My pull request is based on the commit fde16c7

@ProLoser
Copy link
Member

@dmitry-dedukhin this approach looks better than #66, but shouldn't it be .removeClass() rather than leaving a chance of unexpected behavior? (since if isPristine is true, we'd always want this property removed).

ProLoser added a commit that referenced this pull request Jan 28, 2014
@ProLoser
Merge pull request #133 from dmitry-dedukhin/input_keep_pristine
60fa132 
Keep pristine state when attached to input tag
@ProLoser ProLoser merged commit 60fa132 into angular-ui:master Jan 28, 2014
@ProLoser
Copy link
Member

Nevermind, I missed that the if-statement doesn't wrap the pristine toggle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitry-dedukhin @ProLoser