This repository was archived by the owner on Sep 8, 2020. It is now read-only.
fix(modeconvert): update AngularJS model with a string. #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2013 15:57
parse String $viewValue form “tag1,tag2” to [“tag1”, “tag2”] before converting to Select2 model
|
I can confirm this seems to fix it. Im not entirely sure why. |
BaconSoap
added a commit
that referenced
this pull request
Dec 17, 2013
fix(modeconvert): update AngularJS model with a string.
|
Fixes #114 |
GFoley83
added a commit
to GFoley83/ui-select2
that referenced
this pull request
Feb 17, 2014
Bug related to PR angular-ui#115. Updated code to split on separator option instead of a comma. Splitting on a comma breaks if selected tag contains a comma e.g. selecting "Springsteen, Bruce" would cause two tags.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse String $viewValue form “tag1,tag2” to [“tag1”, “tag2”] before
converting to Select2 model
Fixes the test: Updating the select2 model will update AngularJS model with a string.