ui-select2 does not split on select2's "separator" option for multiple

GFoley83 · GFoley83 · commit 4860f353d5dc · 2014-02-18T08:33:00.000+13:00
Bug related to PR angular-ui#115. Updated code to split on separator option instead of a comma. Splitting on a comma breaks if selected tag contains a comma e.g. selecting "Springsteen, Bruce" would cause two tags.
diff --git a/src/select2.js b/src/select2.js
@@ -98,7 +98,7 @@ angular.module('ui.select2', []).value('uiSelect2Config', {}).directive('uiSelec
               if (opts.multiple) {
                 var viewValue = controller.$viewValue;
                 if (angular.isString(viewValue)) {
-                  viewValue = viewValue.split(',');
+                  viewValue = viewValue.split(opts.separator);
                 }
                 elm.select2(
                   'data', convertToSelect2Model(viewValue));

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ angular.module('ui.select2', []).value('uiSelect2Config', {}).directive('uiSelec`
`98`	`98`	`if (opts.multiple) {`
`99`	`99`	`var viewValue = controller.$viewValue;`
`100`	`100`	`if (angular.isString(viewValue)) {`
`101`		`- viewValue = viewValue.split(',');`
	`101`	`+ viewValue = viewValue.split(opts.separator);`
`102`	`102`	`}`
`103`	`103`	`elm.select2(`
`104`	`104`	`'data', convertToSelect2Model(viewValue));`