This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix label for input #238
Closed
Fix label for input #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…propagated to the document
…of the input's id to create labels that will focus the select
Added the `input-id` attribute to the `ui-select` directive to add an id to the input element so that external label elements can be attached to it.
Added the `input-id` attribute to the `ui-select` directive to add an id to the input element so that external label elements can be attached to it.
|
@georeith can you clean this PR and remove all /dist files? |
|
Hi. |
|
Hi, I can't get external "label for" to work, tried with 0.14.1 (should have the fix merged in as far as I can tell). What I see with debugger is that id value is correctly placed for the search input field, but because it has "display: none" initially, clicking the label does not change focus to input. Example Plunkr: http://plnkr.co/edit/u8dIsIuy4L90sMNYUfud?p=preview Any suggestions? |
|
Closing due to history being broken (there should be no merge or revert commits), and this being significantly outdated. Feel free to open a new PR with issues addressed re-implementing everything desired. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #236