This repository was archived by the owner on Oct 2, 2019. It is now read-only.
add input id to search <input> if present on ui-select directive as input-id #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add one simple test to it so we can merge asap? |
|
tests added! (sorry for the whitespace cleanup, my editor couldn't help itself). |
| }); | ||
| }); | ||
|
|
||
| it('should add an id to the search input field', function () { |
There was a problem hiding this comment.
Looks like same test is repeated twice
There was a problem hiding this comment.
I wanted to test both single and multiple because they are very different beasts (even though they both have the same text input name right now). The it name is the same because the describe names will disambiguate them. I'm happy to remove one if you want.
I'd prefer to keep the multiple test because that's the one I care about most (and that search field is always on display so much more likely to be used for <label for="...">.
dimirc
added a commit
that referenced
this pull request
Oct 3, 2015
add input id to search <input> if present on ui-select directive as input-id
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1195
fixes #236