This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Reverting #1822 #1832
Merged
Reverting #1822 #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many problems with this change. Reverted it for this reason. This reverts commit 0d81493.
Jefiozie
added a commit
to Jefiozie/ui-select
that referenced
this pull request
Oct 31, 2016
* Revert "Bug fix - Search input isn't blocked (angular-ui#1822)" Many problems with this change. Reverted it for this reason. This reverts commit 0d81493. * cleaning up comments
kboga
pushed a commit
to kboga/ui-select
that referenced
this pull request
Nov 29, 2016
* Revert "Bug fix - Search input isn't blocked (angular-ui#1822)" Many problems with this change. Reverted it for this reason. This reverts commit 0d81493. * cleaning up comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted commit from #1822 as this change breaks the control in specific scenario's .
Check out the feedback on this commit
I think @aaronroberson or @user378230 should merge this and take a new look at #1822.