Skip to content

Commit 0d81493

Browse files
nabilnaffaraaronroberson
authored andcommitted
Bug fix - Search input isn't blocked (angular-ui#1822)
* fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode. * Revert "fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode." This reverts commit ffcf66c. * fixed a bug: User input keys to search input isn't blocked when search-enabled is set to false and all items are selected in multiple select mode.
1 parent 10a60fa commit 0d81493

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/uiSelectController.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ uis.controller('uiSelectCtrl',
383383
ctrl.select = function(item, skipFocusser, $event) {
384384
if (item === undefined || !_isItemDisabled(item)) {
385385

386-
if ( ! ctrl.items && ! ctrl.search && ! ctrl.tagging.isActivated) return;
386+
if ( (!ctrl.items || !ctrl.items.length) && ! ctrl.search && ! ctrl.tagging.isActivated) return;
387387

388388
if (!item || !_isItemDisabled(item)) {
389389
// if click is made on existing item, prevent from tagging, ctrl.search does not matter
@@ -645,6 +645,9 @@ uis.controller('uiSelectCtrl',
645645
});
646646
}
647647
}
648+
}else{
649+
e.preventDefault();
650+
e.stopPropagation();
648651
}
649652

650653
});

0 commit comments

Comments
 (0)