This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectController): Select by click on non-multiple tagging (bis) #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronroberson Could you look at this PR, please? It's my first, so feedback would be appreciated. |
| if(ctrl.tagging.isActivated) { | ||
| // if click is made on existing item, prevent from tagging, ctrl.search does not matter | ||
| var manualSelection = false; | ||
| if($event && $event.type === 'click' && item) |
There was a problem hiding this comment.
We have a check down below already... (L438)
if ($event && $event.type === 'click') {
ctrl.clickTriggeredSelect = true;
}Can you combine this/assignment into one and then just check for item?
|
This PR is the cause of this bug: #1806. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in tagging mode, not multiple (taggingLabel === false), selecting an item by click was instead calling taggingFunc(). This fix checks
for this manual selection, whether ctrl.search is filled or not and
acts accordingly.
Same changes made in #1439 that were mysteriously lost.
Closes #1496