Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Can't select elements with click when when using tagging #1496

Closed
BrentWheeldon opened this issue Mar 16, 2016 · 11 comments · Fixed by #1727
Closed

Can't select elements with click when when using tagging #1496

BrentWheeldon opened this issue Mar 16, 2016 · 11 comments · Fixed by #1727
Labels
needs: investigation

Comments

@BrentWheeldon
Copy link

I am having the same issue as #1357 using 0.16.0 (from bower).

I see that this was fixed in #1439, but I can't find that commit either in the 0.16.0 tag, nor master. Am I missing something?
@BrentWheeldon BrentWheeldon changed the title Canst select elements with click when when using tagging Can't select elements with click when when using tagging Mar 16, 2016
@wesleycho
Copy link
Contributor

This does seem missing - not sure what happened to it - @aaronroberson any idea why it's not appear in the history in master?

@aaronroberson
Copy link
Contributor

That's odd, I'll look into it later today once I get the chance!

@Vnthf
Copy link

Vnthf commented Mar 30, 2016

I have a same problem

@issamm
Copy link

issamm commented Apr 8, 2016

Hi, the issue 1439 seems to be still present : tried with v1.6.1.

A handler function is missing ('keyup' event) inside the uiSelectSingle directive.
=> It has been included on the attached file, and it seems to work correctly.
Pull request coming soon...
select.js.txt

@user378230
Copy link
Contributor

@issamm your PR might already be covered by #972

@issamm
Copy link

issamm commented Apr 8, 2016

This is what I was going to say, lol. Thank you.
We did almost the same modification : but viniciusdacal's commit is cleaner ;)

@hagayl
Copy link

hagayl commented May 9, 2016

I'm facing this issue as well, doesn't seem to be fixed yet (v1.6.1).
It's caused by setting the tagging-label to false (tagging-label="false").
A workaround for the meantime can be setting it to an empty string instead: tagging-label=""

@gamebox
Copy link

gamebox commented Jun 17, 2016

Thanks for that easy quickfix @hagayl

@jspizziri
Copy link

Thanks @hagayl!

@stefanmeschke
Copy link

If you leave tagging-label blank it isn't possible to add anything which is not in the list of items. I need the ui-select for selecting an item or add a new item.

@aaronroberson
Copy link
Contributor

Can someone create a new PR please?

@kfedorov kfedorov mentioned this issue Jul 13, 2016
Merged
aaronroberson pushed a commit that referenced this issue Jul 19, 2016
@kfedorov @aaronroberson
fix(uiSelectController): Select by click on non-multiple tagging (bis) (
3dfde71 
#1727)

* When in tagging mode, not multiple (taggingLabel === false), selecting
an item by click was instead calling taggingFunc(). This fix checks
for this manual selection, whether ctrl.search is filled or not and
acts accordingly.

Same changes mad in #1439 that were mysteriously lost.
Fixes #1357, #1496 and #1409

* Simplification to combine ctrl.clickTriggeredSelect in one assignment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs: investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(uiSelectController): Select by click on non-multiple tagging (bis)
10 participants
@aaronroberson @BrentWheeldon @hagayl @gamebox @jspizziri @wesleycho @issamm @stefanmeschke @Vnthf @user378230