This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelect) support data-multiple attribute #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user378230
force-pushed
the
fix-data-attrs
branch
2 times, most recently
from
68c55dc to
7a45bf2
Compare
|
I'm not sure what your claimed support is, but here's a snippet in UI Bootstrap for what we check for: https://github.com/angular-ui/bootstrap/blob/master/src/tabs/tabs.js#L224-L234 |
| @@ -10,7 +10,10 @@ uis.directive('uiSelectMatch', ['uiSelectConfig', function(uiSelectConfig) { | |||
|
|
|||
| // Gets theme attribute from parent (ui-select) | |||
| var theme = tElement.parent().attr('theme') || uiSelectConfig.theme; | |||
| var multi = tElement.parent().attr('multiple'); | |||
|
|
|||
| var multi = angular.isDefined(tElement.parent().attr('multiple')) || | |||
There was a problem hiding this comment.
Probably worth caching tElement.parent() above and rewriting to remove duplicate calls to .parent()
user378230
force-pushed
the
fix-data-attrs
branch
2 times, most recently
from
23ce67e to
8359962
Compare
uiSelectMatch was a special case where the non-normalised attribute is checked, therefore using data-multiple resulted in the single select match template being loaded. Closes angular-ui#1451
user378230
force-pushed
the
fix-data-attrs
branch
from
8359962 to
8111ad1
Compare
|
Yeah I was being somewhat lazy, updated if you get a chance to review. . |
|
LGTM |
radim-poloch
added a commit
to kirillbuga/ui-select
that referenced
this pull request
Sep 17, 2016
kirillbuga
pushed a commit
to kirillbuga/ui-select
that referenced
this pull request
Sep 20, 2016
angular-ui#1519 auto open dropdown on tab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uiSelectMatch was a special case where the non-normalised
multipleattribute is checked, therefore usingdata-multipleresulted in the single select match template being loaded instead of the multiple-select-match template.test is more involved than I would have liked but I couldn't see any other way to test it.
Closes #1451