angular-ui#1519 auto open dropdown on tab

radim-poloch · radim-poloch · commit 28a21e252491 · 2016-09-17T14:30:40.000+02:00
diff --git a/dist/select.js b/dist/select.js
@@ -468,7 +468,7 @@
 
         focusser.bind("keyup input", function(e){
 
-          if (e.which === KEY.TAB || KEY.isControl(e) || KEY.isFunctionKey(e) || e.which === KEY.ESC || e.which == KEY.ENTER || e.which === KEY.BACKSPACE) {
+          if (KEY.isControl(e) || KEY.isFunctionKey(e) || e.which === KEY.ESC || e.which == KEY.ENTER || e.which === KEY.BACKSPACE) { // RADIM EDIT: we want to open the dropdown if reached by tab key
             return;
           }
           
diff --git a/src/select.js b/src/select.js
@@ -460,7 +460,7 @@
 
         focusser.bind("keyup input", function(e){
 
-          if (e.which === KEY.TAB || KEY.isControl(e) || KEY.isFunctionKey(e) || e.which === KEY.ESC || e.which == KEY.ENTER || e.which === KEY.BACKSPACE) {
+          if (KEY.isControl(e) || KEY.isFunctionKey(e) || e.which === KEY.ESC || e.which == KEY.ENTER || e.which === KEY.BACKSPACE) { // RADIM EDIT: we want to open the dropdown if reached by tab key
             return;
           }
           

Original file line number	Diff line number	Diff line change
`@@ -468,7 +468,7 @@`
`468`	`468`
`469`	`469`	`focusser.bind("keyup input", function(e){`
`470`	`470`
`471`		`- if (e.which === KEY.TAB \|\| KEY.isControl(e) \|\| KEY.isFunctionKey(e) \|\| e.which === KEY.ESC \|\| e.which == KEY.ENTER \|\| e.which === KEY.BACKSPACE) {`
	`471`	`+ if (KEY.isControl(e) \|\| KEY.isFunctionKey(e) \|\| e.which === KEY.ESC \|\| e.which == KEY.ENTER \|\| e.which === KEY.BACKSPACE) { // RADIM EDIT: we want to open the dropdown if reached by tab key`
`472`	`472`	`return;`
`473`	`473`	`}`
`474`	`474`
Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@`
`460`	`460`
`461`	`461`	`focusser.bind("keyup input", function(e){`
`462`	`462`
`463`		`- if (e.which === KEY.TAB \|\| KEY.isControl(e) \|\| KEY.isFunctionKey(e) \|\| e.which === KEY.ESC \|\| e.which == KEY.ENTER \|\| e.which === KEY.BACKSPACE) {`
	`463`	`+ if (KEY.isControl(e) \|\| KEY.isFunctionKey(e) \|\| e.which === KEY.ESC \|\| e.which == KEY.ENTER \|\| e.which === KEY.BACKSPACE) { // RADIM EDIT: we want to open the dropdown if reached by tab key`
`464`	`464`	`return;`
`465`	`465`	`}`
`466`	`466`