This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectMultipleDirective): Fixes checks for existing tags during multiple tag creation and selection #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout dist/ files based off the latest ui-select v0.14.9 release.
aaronroberson
added a commit
that referenced
this pull request
Mar 4, 2016
fix(uiSelectMultipleDirective): Fixes checks for existing tags during multiple tag creation and selection
| // verify the new tag doesn't match the value of a possible selection choice or an already selected item. | ||
| if ( | ||
| stashArr.some(function (origItem) { | ||
| return angular.equals(origItem, $select.tagging.fct($select.search)); |
There was a problem hiding this comment.
Was there any hidden reason for choosing
return angular.equals(origItem, $select.tagging.fct($select.search));in this line, and not the same as below
return angular.equals(origItem, newItem);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as #647 without the dist/ files.