This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix for filteredItems in async loading data #1464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2016 11:12
the already pre-loaded ngModel data is now compared with angular.equals instead of Array.indexOf which caused elements not to be correctly filtered
|
This issue has been resolved and merged with PR #1473 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading data in async mode into the directive, if ngModel had already preloaded data, the filter was not applied correctly. This issue was due to behaviour of Array.indexOf prototype method. When comparing arrays of objects, the comparison is made by object reference and always fails.
Switched to angular.isEqual for in depth comparison of objects (this also aids to get rid of $ prefixed variables that angular adds to objects)