Prevent '$apply already in progress' error at angular v1.3.0-beta-12+

[dimirc]

Problem was caused by this commit in angular code.

I already also send them a comment with a proposal on how to prevent this.

If they don't fix/change at angular's end, then I'll merge this in couple of days.

Working plunker

Closes #124

[tikiatua]

@dimirc thank you for looking into the issue. That might have been the case. This would also explain, why I could not reproduce the problem on plunkr where I was using a stable release of angular.

[petebacondarwin]

@dimirc - Are you sure this fixes the problem? The way you have done it, the call to focus() will still be inside a $apply block. You need to tell $timeout not to wrap the function in an apply:

$timeout(function(){
  ctrl.focusser[0].focus();          
}, 0, false);

Perhaps a unit test will help nail this down?

[dimirc]

@petebacondarwin before the $timeout we have this line ctrl.open = false; that will hide the search input that was the element in conflict.

This fix actually works since I'm defering the focus() event to next cycle where there isn't a search input shown anymore so no .blur() event that will conflict neither.

Anyway I think that your suggestion of setting the timeout with invokeApply = false is valid since we'll prevent an unnecessary digest cycle.

Landed as 6dfc5d0