Prevent digest cycle problem on enter/tab #115
Conversation
Wrap function calls in the _onKeyDown function in $timeout to prevent problems with the digest cycle after selecting an item using the keyboard (i.e. tab or enter).
|
Keep I mind this function is already called inside an $apply so there shouldn't be the need for the $timeout Did you actually had any problem with the way it is currently? |
|
Yes, I did actually run into the problem. This could have been due to the fact, that I used the directive inside another custom directive that was watching the object used for ngModel and triggered some custom events on any change to the object (sorry this might be a little confusing to understand) |
|
Can you setup a simplified Plunker reproducing the issue so I can check it if we can do something at the directive to prevent it? |
|
Sure.. Will try to set one up |
|
Hmm.. I was not able to reproduce the problem in a simple plunker yet. Actually it does not seem to be a problem with an additional watcher but with the dispatch of a focus() event on the element (line 259: ctrl.focusser[0].focus()), which is handled through jquery (being included in the site for other purposes) and results in a [$rootScope:inprog] error. The error does not occur, if I set breakpoints in the debugger to track it down further |
|
I'd need some code to check this. Try to put together a Plunker with this error or specific instruction how to produce the error so we can check and try to help better. Sent from my iPhone
|
Wrap function calls in the _onKeyDown function in $timeout to prevent problems with the digest cycle after selecting an item using the keyboard (i.e. tab or enter).