Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Dropdown direction issue on webkit #1016

Closed
gaetansnl opened this issue Jun 16, 2015 · 11 comments
Closed

Dropdown direction issue on webkit #1016

gaetansnl opened this issue Jun 16, 2015 · 11 comments

Comments

@gaetansnl
Copy link

The problem is on this line (in uiselect directive), on Chrome (43) $document[0].documentElement.scrollTop return 0

 else if (offset.top + offset.height + offsetDropdown.height > $document[0].documentElement.scrollTop + $document[0].documentElement.clientHeight)

It works if i replace by

 else if (offset.top + offset.height + offsetDropdown.height > $document[0].body.scrollTop + $document[0].documentElement.clientHeight)

But it doesn't work anymore on Firefox now...

Anyone have this problem ?

EDIT :
window.pageYOffset work on both

Thank you

@hengun348
Copy link

I can confirm this issue as well

@acetrand
Copy link

Im seeing this also in Chrome. Please fix asap.

@gaetansnl
Copy link
Author

I will make a pull req.
It works fine after my fix.

@acetrand
Copy link

@pulse14 Please do. I didnt follow where you put the window.pageYOffset so I'm holding my breath for your PR 😉

@sricc
Copy link

sricc commented Jun 26, 2015

Seeing this as well.

@jonasflesch
Copy link

I confirm that this fixed the problem for me.

@timcosta
Copy link

+1. This is a pretty serious bug and the PR needs to be accepted.

@tinybigideas
Copy link

+1 for the PR to be accepted. Great fix @pulse14. I've accepted this into my build and it has corrected the issue. Hopefully this is accepted into the master sooner rather than later!

@Iku-turso
Copy link

+1.

@evillemez
Copy link

+1 I can also confirm the fix by @pulse14 works. Thank you!

@dimirc
Copy link
Contributor

dimirc commented Sep 28, 2015

Should be solved with #1212

@dimirc dimirc closed this as completed Sep 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants