Skip to content

Commit f788aa5

Browse files
committed
Fix dropdown direction issue on webkit
issue angular-ui#1016
1 parent 2d1422d commit f788aa5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/uiSelectDirective.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
uis.directive('uiSelect',
2-
['$document', 'uiSelectConfig', 'uiSelectMinErr', 'uisOffset', '$compile', '$parse', '$timeout',
3-
function($document, uiSelectConfig, uiSelectMinErr, uisOffset, $compile, $parse, $timeout) {
2+
['$document', '$window', 'uiSelectConfig', 'uiSelectMinErr', 'uisOffset', '$compile', '$parse', '$timeout',
3+
function($document, $window, uiSelectConfig, uiSelectMinErr, uisOffset, $compile, $parse, $timeout) {
44

55
return {
66
restrict: 'EA',
@@ -270,7 +270,7 @@ uis.directive('uiSelect',
270270
var offsetDropdown = uisOffset(dropdown);
271271

272272
// Determine if the direction of the dropdown needs to be changed.
273-
if (offset.top + offset.height + offsetDropdown.height > $document[0].documentElement.scrollTop + $document[0].documentElement.clientHeight) {
273+
if (offset.top + offset.height + offsetDropdown.height > $window.pageYOffset + $document[0].documentElement.clientHeight) {
274274
dropdown[0].style.position = 'absolute';
275275
dropdown[0].style.top = (offsetDropdown.height * -1) + 'px';
276276
element.addClass(directionUpClassName);

0 commit comments

Comments
 (0)