0.2.0 not working in IE8 without es5-shim #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nateabele
added a commit
that referenced
this pull request
Sep 7, 2013
0.2.0 not working in IE8 without es5-shim
|
Did this fix make it into 2.0? I have installed 2.0 via bower as of less than a week ago and still encounter this error - ui-router only works with es5-shim @nateabele Also, if it's any help, I am using IE8 WinXP Virtual Machine from http://www.modern.ie/en-us/virtualization-tools#downloads I am on a Mac OSX again using VirtualBox w/ IE8 on XP, very basic router implementation (looks straight out of the example) FWIW I would not be opposed to being told that if you're on XP, you deserve to have an additional script tag loaded :-) just wanted to make sure you were aware that this bug isn't fully addressed (possibly) IE8 XP != IE8 anywhere else, just fyi. Is ui-router not meant to support XP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like most of the ui-router code uses angular.forEach, except for this one spot.