v0.2.0 & IE8

[ocombe]

I recently updated from v0.0.1 to v0.2.0 and I just had to change "ui.state" to "ui.router" and everything seemed to be working fine, until I tried IE8 and got this nice error:
"TypeError: Object does not support property or "forEach" method undefined"

Sorry,but the IE8 debugger sucks and I don't have the line for the error...
I did a bit of digging and the error seems to be in this block of code:

// Resolve template and dependencies for all views.
      forEach(state.views, function (view, name) {
        var injectables = (view.resolve && view.resolve !== state.resolve ? view.resolve : {});
        injectables.$template = [ function () {
          return $view.load(name, { view: view, locals: locals, params: $stateParams, notify: false }) || '';
        }];

        promises.push($resolve.resolve(injectables, locals, dst.resolve, state).then(function (result) {
          // References to the controller (only instantiated at link time)
          result.$$controller = view.controller;
          // Provide access to the state itself for internal use
          result.$$state = state;
          dst[name] = result;
        }));
      });

In the file state.js line ~363 : https://github.com/angular-ui/ui-router/blob/master/src/state.js

I can get a console.log just before promises.push but nothing after.

[trask]

I just ran into the same issue. You can use es5-shim to workaround. I submitted a PR to not require es5-shim. See #392.

[ocombe]

good catch, this should help solving this bug

[cateland]

Angular UI team stated they won't activelly support IE8/7

[nateabele]

I just merged the PR from @trask. Please update & try again.

[laurelnaiad]

When I search the code for IE8, I see this:

// Used instead of Object.keys() for IE8 compatibility

And I see @nateabele merging a fix for IE8 expeditiously.

What I don't see is the Angular-UI team stating they won't actively support IE8/7.

Angular UI team stated they won't activelly support IE8/7

@cateland, are you referring to the Angular-UI team at large? I'm hoping so. What the widgets need is a bit different than what the router needs and I'm sure trying to support IE8 at that level would be a terrible experience.

Unfortunately I have a vested interest the router continuing to work with IE8 and I hope that it will!

[cateland]

@stu-salsbury yes i was refering to the Angular-UI team at large.
But they don't prevent contributor to submit patch targeted at IE7/8.
Im also deeply interested into having ui-router to work on those plateforms.

[nateabele]

I don't really make a habit of testing on IE, but we accept bug reports for any browser supported by Angular itself.

@ocombe Please verify that the PR resolves your issue and if so, do us a favor and close this issue. Thanks.

[ocombe]

I confirm that it is fixed by d2ced6b
Thanks for the reactivity !

[laurelnaiad]

@nateabele I don't blame you. I just set up a virtualbox to test IE8 only to find that it didn't even support chai's expect syntax (never mind should)! Array slice doesn't even work right without a shim. It's ugly!