Skip to content

style(npmignore): add bower_components folder to ignore list #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

americoneto1
Copy link

PR to exclude bower_components folder when publish packages to NPM registry, it´s related to #1683

@nateabele
Copy link
Contributor

Make sure you follow the contributor guidelines when submitting PRs. Here's a handy little checker: http://prjs.radify.io/#/angular-ui/ui-router/pulls/2498

@americoneto1 americoneto1 changed the title Add bower_components folder to ignore list (NPM) style(npmignore): Add bower_components folder to ignore list Jan 30, 2016
@americoneto1
Copy link
Author

Thanks @nateabele ! I updated PR subject, it's ok now?

@nateabele
Copy link
Contributor

It's based on the actual commit message, not the PR title (I keep forgetting to update the PR hinting tool, sorry). It's for our changelog generator, otherwise things get all wonky.

@christopherthielen
Copy link
Contributor

To fix the commit message:

  • Use interactive rebase: git rebase -i
  • When the editor opens, change the commit from pick to r for "reword".
  • Change the commit message to match the contributor guidelines, save and quit.
  • Force push to the PR branch git push --force

@americoneto1 americoneto1 changed the title style(npmignore): Add bower_components folder to ignore list style(npmignore): add bower_components folder to ignore list Feb 1, 2016
Americo Neto and others added 2 commits January 31, 2016 23:28
@nateabele
Copy link
Contributor

Merged manually: 508f9ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants