Skip to content

Create an effective .npmignore #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gustavohenke opened this issue Jan 10, 2015 · 6 comments · Fixed by #1701
Closed

Create an effective .npmignore #1683

gustavohenke opened this issue Jan 10, 2015 · 6 comments · Fixed by #1701
Assignees
Milestone

Comments

@gustavohenke
Copy link
Contributor

Hey,
I just installed UI Router thru NPM, and it gave me a heavy (6.7 MB), bloated package:

When I opened the .npmignore, I found that its contents aren't effective at all:

# master only
build
site

# common
node_modules
bower_components
.DS_Store
*~

# webstorm files
.idea

I suggest adding at least the following directories to the list:

  • config
  • lib
  • sample
  • test

I wanted to send a PR with this modifications, but I couldn't find anywhere in this repo a file called .npmignore.

Guys, can we do this? It will make everyone's CI builds faster!

@christopherthielen christopherthielen self-assigned this Jan 21, 2015
@christopherthielen christopherthielen added this to the 0.2.14 milestone Jan 21, 2015
@christopherthielen
Copy link
Contributor

thanks for the heads up

@ilanbiala
Copy link

@gustavohenke why don't you submit a PR and @christopherthielen will review it so that they can work on other more complicated things for 0.2.14?

@gustavohenke
Copy link
Contributor Author

@ilanbiala Yes sir! See #1701

@americoneto1
Copy link

Could you please include bower_components folder in .npmignore? I had install today and it comes with almost 80 MB in DefinitelyTyped folder

@nateabele
Copy link
Contributor

@americoneto1 Sure. It'll probably happen faster if you submit a PR. 😄

@americoneto1
Copy link

Nice! I'll do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants