Skip to content

fix(uiSrefActive): update the active classes when compiled #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2016
Merged

fix(uiSrefActive): update the active classes when compiled #2448

merged 1 commit into from
Jan 24, 2016

Conversation

fpipita
Copy link
Contributor

@fpipita fpipita commented Jan 7, 2016

This PR makes sure the active classes are applied during the directive compilation phase so that they are available even after $stateChangeSuccess has already been fired.

Plunker showing the issue: https://plnkr.co/edit/z3kdm41eyuXK052fsflH?p=preview

@christopherthielen
Copy link
Contributor

Hi, thanks for the PR. Is there a related issue ticket that it closes?

Your plunker seems to be working fine for me. However, I see what your PR is fixing and it looks good to me at first glance. Can you rebase against the current feature-1.0 and squash commits?

@fpipita
Copy link
Contributor Author

fpipita commented Jan 24, 2016

Hi, I rebased the PR against feature-1.0 but I'm not quite sure about what it should be squashed against, could you please explain me? :)

The plunker is not working because as shown in the image below, the text "I should get the active class:/" is not getting the active class.
plunkr

Issue #2392 is related to this one even though it referred the master branch.

@christopherthielen
Copy link
Contributor

what it should be squashed against

my mistake, no squash necessary

the text "I should get the active class:/" is not getting the active class.

aah, I see now.

Thanks!

christopherthielen added a commit that referenced this pull request Jan 24, 2016
fix(uiSrefActive): update the active classes when compiled
@christopherthielen christopherthielen merged commit 6c3271a into angular-ui:feature-1.0 Jan 24, 2016
@fpipita fpipita deleted the feature-1.0 branch May 3, 2016 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants