fix(stateDirectives): call update route state on page load #2392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest PR #2363 removed a line from
stateDirectives.js
. This creates an issue. More precisely, when the page is loaded the update() function is not called the way it is expected.Let me clarify this on an example:
Lets assume that we have an abstract state
private
. Theprivate
state has children states:index
andsettings
. With routes#/private
and#/settings
.And we have a navbar:
Here we assume that every time we are in the
index
andsettings
ui-router should append class.active
to.parent
element. But in fact it never appends it on page load. It only appends it when the user clicks<a ui-sref="private.index">main</a>
or<a ui-sref="private.settings">settings</a>
links. Thats because the update is never called on page load. This PR solves the issue.