Skip to content

feat(ui-sref): support URL fragments in html5Mode #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat(ui-sref): support URL fragments in html5Mode #1455

wants to merge 1 commit into from

Conversation

encounter
Copy link

This provides support for specifying URL fragments in ui-sref attributes when HTML5Mode is enabled.

Thanks to @mismith for his original work in #1187.

@nateabele
Copy link
Contributor

This syntax looks pretty hacky, and actually prevents the fragment from being parameterized, which is probably the default use case.

@encounter
Copy link
Author

I went ahead and refactored it and fixed the tests, hopefully it's more straightforward now. Let me know if there's anything else I can do.

@encounter encounter closed this Oct 15, 2014
@encounter
Copy link
Author

This doesn't work as expected after all, I'll see if I can find a better solution.

@mismith
Copy link

mismith commented Oct 15, 2014

I'm not sure if I understand @nateabele's comment correctly, but if by "prevents the fragment from being parameterized" he means you can't use syntax like: ui-sref="stateName({param1: expressionOrValue, '#': hashExpressionOrValue})" then I know the code I wrote does indeed handle that. 2¢

@nateabele
Copy link
Contributor

@mismith Correct.

@OnkelTem
Copy link

Any progress?

@stephengardner
Copy link

Is this feature added yet into ui router? It's been a while now

@nateabele
Copy link
Contributor

Don't think so. If anybody wants to pick up the torch on this PR, I'd be happy to coach them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants