support setting url #fragments in state params

[mismith]

As per @sadlerw's request in #701

NB: obviously HTML5 mode needs to be enabled for this to have any effect
Supports both formats:

• ui-sref="mystate(myparams)#{{ myhashexpression }}"
• ui-sref="mystate({myparam1: myvalue1, myparam2: myvalue2, '#': myhashexpression})"

[timkindberg]

Hi @mismith thanks for contributing. Several things need to be fixed though, all of which are summarized here: https://github.com/angular-ui/ui-router#contribute

1. Needs test coverage
2. Needs proper commit message formatting
3. You have jshint issues

Running "jshint:all" (jshint) task
Linting src/urlRouter.js ...ERROR
[L392:C1] W099: Mixed spaces and tabs.
        url += '#' + params['#'];
Linting build/angular-ui-router.js ...ERROR
[L1712:C1] W099: Mixed spaces and tabs.
        url += '#' + params['#'];
Warning: Task "jshint:all" failed.

[cedricziel]

@mismith any progress? If needed, i'd try to pr to your feature branch

[mismith]

Sorry guys, I just don't have time to do this properly right now, feel free to take what I have if you need it

[OnkelTem]

Murray, would you provide some example on how this is supposed to work?
Specifically, should location be rewritten after state transition to include #<fragment>? From what I tested this is not happening: ui-sref directive is now correctly creates URL with fragment, but when clicking on a link, no fragment is added to location.href

[mismith]

@OnkelTem: "should location be rewritten after state transition to include #". Yes.
Perhaps since I created this PR the master branch has changed in such a way that this no longer works—or maybe browsers have evolved themselves—but back then it did indeed add the #fragment to the URL after/on clicking the link.

[mismith]

Yes, it looks like the following line in the latest master branch is what's stripping out the # param:

toParams = toState.params.$$values(toParams);

Then, a little lower down, another line also filters out the # again:

toParams = filterByKeys(to.params.$$keys(), toParams || {});

Basically, by the time we get to building a URL in the parent $state.transitionTo method, we no longer have toParams['#'] set. Finally, when we internally call UrlMatcher.format() from within $urlRouter.push(), it also strips out the # again.