Impossible to disable html5Mode with angular 1.3.0-rc.3 #1397 #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch itself looks fine, but please refer to the contributor guidelines. |
|
@nateabele, is it ok now? or should I include a test for this?, I'm not sure since the BC starts from 1.3. |
|
The commit message looks fine, but a bug fix needs a test case. @christopherthielen recently added 1.3 to the test suite, so it should be possible to make a failing test case that is fixed by this patch. Otherwise, one of us can add a test when we have time. Thanks. |
Since angular/angular.js@dc3de7f angular accepts both boolean and objects like {enabled: true, requireBase: false} causing the evaluation to be always true. In order to allow the use of ui-router with angular 1.3 a fix has been made, it checks if the value is an object and gets its enabled property value. Fixes #1397
|
@nateabele, now? |
nateabele
added a commit
that referenced
this pull request
Sep 26, 2014
Impossible to disable html5Mode with angular 1.3.0-rc.3 #1397
|
Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.