ui-sref not correctly setting href attribute with angular 1.3

[theJoeBiz]

I've been building an app with the angular 1.3 release candidate and another one of my team members mentioned that when right clicking and opening in a new tab it wasn't maintaining the html5Mode(off) hashbang.

Example:

<a ui-sref="home"></a>

should resolve to

<a href="#/home"></a>

but instead it's resolving to

<a href="/home"></a>

This is only happening with angular 1.3.x.

So I looked into it and believe I found the issue.

Previous to angular 1.3.x, $locationProvider.html5Mode() used to simply return a boolean. Now, it returns an object like so:

{
  enabled: false,
  requireBase: true
}

I'll make a pull request, but just wanted the issue documented.

Oh, here's a plunker. Try to right click and open in a new window/tab and you'll receive a broken page because the hash is missing.

[christopherthielen]

Hi @theJoeBiz Thanks for the detailed issue report. This is dupe #1397 and we just merged the fix in #1404

[theJoeBiz]

Woops! Was just coming back to close this because I realized my fork was out of date.

[christopherthielen]

👍 appreciate the effort