Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

refactor(carousel): simplify active in slide directive #1602

Closed
wants to merge 2 commits into from
Closed

refactor(carousel): simplify active in slide directive #1602

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b47b5be
refactor(carousel): simplify active in slide directive
mvhecke Jan 17, 2014
88d782e
refactor(carousel): simplify active in slide directive
mvhecke Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions src/carousel/carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,38 +297,17 @@ function CarouselDemoCtrl($scope) {
</example>
*/

.directive('slide', ['$parse', function($parse) {
.directive('slide', [function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the array to save 2 extra characters :-D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changed it!

return {
require: '^carousel',
restrict: 'EA',
transclude: true,
replace: true,
templateUrl: 'template/carousel/slide.html',
scope: {
active: '=?'
},
link: function (scope, element, attrs, carouselCtrl) {
//Set up optional 'active' = binding
if (attrs.active) {
var getActive = $parse(attrs.active);
var setActive = getActive.assign;
var lastValue = scope.active = getActive(scope.$parent);
scope.$watch(function parentActiveWatch() {
var parentActive = getActive(scope.$parent);

if (parentActive !== scope.active) {
// we are out of sync and need to copy
if (parentActive !== lastValue) {
// parent changed and it has precedence
lastValue = scope.active = parentActive;
} else {
// if the parent can be assigned then do so
setActive(scope.$parent, parentActive = lastValue = scope.active);
}
}
return parentActive;
});
}

carouselCtrl.addSlide(scope, element);
//when the scope is destroyed then remove the slide from the current slides array
scope.$on('$destroy', function() {
Expand Down