refactor(carousel): simplify active in slide directive #1602
Conversation
| @@ -297,7 +297,7 @@ function CarouselDemoCtrl($scope) { | |||
| </example> | |||
| */ | |||
|
|
|||
| .directive('slide', ['$parse', function($parse) { | |||
| .directive('slide', [function() { | |||
There was a problem hiding this comment.
You can remove the array to save 2 extra characters :-D
There was a problem hiding this comment.
Thanks, changed it!
refactor(carousel): simplify active in slide directive
|
Nice one @Gamemaniak 👍 |
|
@pkozlowski-opensource This change breaks in 1.0.x!
EDIT: Seeing that @bekos did it on the accordion too, I guess that we are moving to drop 1.0.x in the next release. |
|
@Foxandxss yup, if we want to have this library moving forward I think we need to focus on 1.2. |
|
Good good, didn't now that we started to 1.2. Good to know in my redo adventure to catch some changes :) |
|
@pkozlowski-opensource We mustn't forget to update the docs dependency to 1.2.x if you plan to release this, just a heads up. |
|
Thnx @Gamemaniak, you are right, done in a61112d |
As part of simplifying things in this project I've attempted to remove unnecessary code for the active slide. While testing it all seems to work.