Skip to content

Configure transform-runtime for all builds #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Configure transform-runtime for all builds #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@
}
]
],
"plugins": "transform-runtime",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an array?

Copy link
Author

@graingert graingert Sep 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deini it can be an array or a string (eg if you only have one plugin). Happy to change it to an array.

"env": {
"test": {
"presets": ["env"]
},
"production": {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this "production" config was not being used.

"plugins": [
"transform-runtime"
]
}
}
}
17 changes: 7 additions & 10 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,24 @@ import commonjs from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve';
import replace from 'rollup-plugin-replace';
import uglify from 'rollup-plugin-uglify';
import { dependencies } from './package.json'

const env = process.env.NODE_ENV;
const config = {
entry: 'src/index.js',
plugins: [],
};

const externals = Object.keys(dependencies).join('|');

if (env === 'es' || env === 'cjs') {
config.format = env;
config.sourceMap = true;
config.external = [
'invariant',
'lodash.curry',
'lodash.isfunction',
'lodash.isobject',
'lodash.isplainobject',
'lodash.map',
'redux',
];
config.external = id => RegExp(`^(${externals})(\/.*)?$`).test(id);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason this is not just config.external = Object.keys(dependencies)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because then it would not externalize package/foo https://rollupjs.org/#peer-dependencies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh gotcha, that makes sense.

config.plugins.push(
babel()
babel({
runtimeHelpers: true,
})
)
}

Expand Down