Configure transform-runtime for all builds #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the demo: graingert@a6f1261#commitcomment-24111563 |
graingert
commented
Sep 6, 2017
| "env": { | ||
| "test": { | ||
| "presets": ["env"] | ||
| }, | ||
| "production": { |
There was a problem hiding this comment.
this "production" config was not being used.
deini
reviewed
Sep 6, 2017
| 'lodash.map', | ||
| 'redux', | ||
| ]; | ||
| config.external = id => RegExp(`^(${externals})(\/.*)?$`).test(id); |
There was a problem hiding this comment.
Is there any reason this is not just config.external = Object.keys(dependencies)?
There was a problem hiding this comment.
because then it would not externalize package/foo https://rollupjs.org/#peer-dependencies
There was a problem hiding this comment.
Ahh gotcha, that makes sense.
deini
changed the title
deini
reviewed
Sep 6, 2017
| @@ -7,14 +7,10 @@ | |||
| } | |||
| ] | |||
| ], | |||
| "plugins": "transform-runtime", | |||
There was a problem hiding this comment.
@deini it can be an array or a string (eg if you only have one plugin). Happy to change it to an array.
deini
approved these changes
Sep 6, 2017
|
@deini any chance of another release? It's also probably worth deprecating 3.5.0 and 3.5.1 |
|
Need to wait for @AntJanus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.