-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Javascript ES6 preprocessor with Babel #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Kauabunga
wants to merge
16
commits into
angular-fullstack:canary
from
Kauabunga:pullrequest-feature-es6-babel
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5619a01
Fixing grammatical errors in endpoint generator
kleinlieu 98bb27d
refactor: deprecate res.[send|json](status)
keriwarr dfe4edd
Merge pull request #702 from kleinlieu/master
DaftMonk d1a52cc
Merge pull request #704 from KeriWarr/master
DaftMonk 13b9630
chore(style) Clarify serveClient logic
andrewstuart 0de04b9
adds npm-debug.log to gitignore
gaboesquivel 49a3a14
Merge pull request #811 from gaboesquivel/ignore-logs
andrewstuart 31bee73
feat(app): add mongodb error handling to quit app if unable to connec…
lirantal 3518fe0
Merge pull request #877 from lirantal/feat-mongodb-error-handle
andrewstuart be22d74
Update passport.js
jaguarus83 97f01cf
Update passport.js
jaguarus83 2a4434e
Update passport.js
jaguarus83 f38629f
Merge pull request #901 from jaguarus83/patch-1
DaftMonk fd777b9
Merge pull request #902 from jaguarus83/patch-2
DaftMonk 0fee45d
Merge pull request #903 from jaguarus83/patch-3
DaftMonk 4c4b93b
feat(app): additional app generator option for ES6 preprocessing usin…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,5 @@ public | |
.idea | ||
client/bower_components | ||
dist | ||
/server/config/local.env.js | ||
/server/config/local.env.js | ||
npm-debug.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do exactly? Why is it different depending on wether babel is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya - bit of a slow reply! Babel is precompiling all the /client js resources to /.tmp.
If we inject all the js resources from /.tmp and /client with the non-babel index.html annotation .... ..... then we get a double up of all ES5 and ES6 items causing angular to die with multiple definitions of modules or something along those lines.