Javascript ES6 preprocessor with Babel #940
Conversation
Fixing grammatical errors in endpoint generator
refactor: deprecate res.[send|json](status)
chore(gitignore) add npm-debug.log to gitignore
…t with mongodb server for some reason when the app will be started with grunt serve, if configured to run with mongodb and the service will not be available, then the app will initialize anyway but mostly this isnt desired and no handling or debug information of why the app has no connection to a mongodb server will be provided
feat(app): exit process if unable to connect to mongo
In default variant if we have an error the code will continue executing
In default variant if we have an error the code will continue executing
Update passport.js
Update passport.js
Update passport.js
…g babel Added a follow up question to the first language selection question to enable ES6 client support with Babel. Related issue: Any plans for es6 and traceur support? #684
|
👍 Nice |
|
This would be really sweet. It looks like there are some merge conflicts that might need to be solved before it can be merged, though. |
| @@ -50,7 +50,11 @@ | |||
| <script src="socket.io-client/socket.io.js"></script><% } %> | |||
| <!-- endbuild --> | |||
|
|
|||
| <% if(filters.babel) { %> | |||
| <!-- build:js(.tmp) app/app.js --> | |||
There was a problem hiding this comment.
What does this do exactly? Why is it different depending on wether babel is used?
There was a problem hiding this comment.
Heya - bit of a slow reply! Babel is precompiling all the /client js resources to /.tmp.
If we inject all the js resources from /.tmp and /client with the non-babel index.html annotation .... ..... then we get a double up of all ES5 and ES6 items causing angular to die with multiple definitions of modules or something along those lines.
|
Also just thought, can you add the babel karma preprocessor and make sure that tests run alright? |
|
Hey Andrew - have just booted up this fork again. Will have a look at getting babel and karma dancing when my time frees up this week. |
|
Also - re the merge conflicts. I had forked from master though submitted the pull request to canary as suggested in the readme. Should I have (forked from canary/merged from canary) before submitting the request? |
|
As Canary has become a bit stale, it's fine to merge to master, especially with a fully working feature. If you don't have the time to tweak this I can go for it. |
|
Sure - Happy for you to gun for it. I had been playing around with karma config to get ES6 client tests working and have just wrapped up getting the changes into the generator. Check it out if you'd like - they're sitting on Kauabunga:pullrequest-feature-es6-babel-and-karma Seems to merge with DaftMonk:master all good. |
|
will do, thanks! |
|
Closed with #998, thank you! |
Added a follow up question to the first language selection question to enable ES6 client support with Babel if they originally select 'Javascript'.
Using the Babel library after better experiences with it over Traceur. Has more readable output and does not require a runtime library component.
Related issue: Any plans for es6 and traceur support? #684