Skip to content

feat(oauth): multiple strategies per account; changeable email #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2014

Conversation

meeDamian
Copy link
Contributor

Changes include:

  • all 3 main networks are selected by default when user chooses to enable oauth¹,
  • added ability to change email in settings,
  • added ability to set password after register through oauth,
  • admins can now confirm user's emails,
  • Google scope updated to match with migration guide,
  • implicit set of default options removed in some places,
  • some unnecessary angular injections removed,
  • some reserved JS words quoted,
  • minor style fixes & cleanup.

Breaking:

  • data fetched from oauth accounts is now stored in a different structure (strategies object on User model),
  • credentials (such as email or phone) are now moved to credentials object array in User model (Helps with keeping track of states of individual methods and having multiple of them).

TODO:

  • ability to manually link oauth accounts from settings,
  • add email hooks in where relevant.

¹ - I'll be adding more networks and they'll be disabled by default

@DaftMonk
Copy link
Member

Not sure that we should enable any oauth strategies by default, they each take a bit of work to set up (setting up google/twitter/facebook oauth secrets/ids, and adding the environment variables)

@meeDamian
Copy link
Contributor Author

It's only selected by default for people who want oauth in app they are about to generate. Also not setting key/secrets won't brake anything, only " Connect with *" buttons won't work.

@DaftMonk
Copy link
Member

Well actually, the way its written, they're selected by default for anyone who uses authentication in their app. Idk, I just think the defaults should all pretty much work out of the box.

So this is something that should go into the next minor version. I'm thinking it would be good to setup a branch specifically for features that are going into the next minor version, so we can continue releasing patches until the minor version is ready to be released.

I'm going to create a canary branch that will focus on 2.1.0 features. Any bugfixes or really small features for the current version can go into master, and be merged into canary to keep it up to date.

A couple things I'd like to go into the next version would be to add support for sequelize as an alternative to mongoose, and perhaps support for password recovery emails, based on remi's PR for modular-fs.

Nice work with this btw!

@remicastaing
Copy link
Contributor

I'm working on a PR for mail address confirmation (through mail) and password recovery for the generator. The WIP can be seen here: in https://github.com/remicastaing/generator-angular-fullstack/tree/mail.

+1 for canary.

@meeDamian
Copy link
Contributor Author

@DaftMonk Yes, I agree, anything I should do?

@DaftMonk
Copy link
Member

Merged into canary.

@JaKXz JaKXz added this to the 2.1.0 milestone Aug 21, 2014
@DaftMonk DaftMonk merged commit ef06272 into angular-fullstack:master Aug 23, 2014
@drastick
Copy link

Why was this reverted?

ce7f342

@remicastaing
Copy link
Contributor

Why was this reverted?

You will find the answer here: #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants