Skip to content

Canary / multiple strategies per account #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
remicastaing opened this issue Aug 26, 2014 · 1 comment
Closed

Canary / multiple strategies per account #492

remicastaing opened this issue Aug 26, 2014 · 1 comment

Comments

@remicastaing
Copy link
Contributor

I'm wondering why the "feat(oauth): multiple strategies per account" was reverted.

Is there already some consensus about a user model for multiple auth strategies?

@DaftMonk
Copy link
Member

I had to revert it because it wasn't supposed to be released in a patch, but I must have accidentally merged it into master when I was trying to merge it into canary, without realizing it, causing it to be in the 2.0.11. It's definitely a larger change and should be in a minor update. Reverting it in master caused it to be reverted in canary when I merged master back into canary.

That said, twitter and google oauth were failing in the demo on heroku when that release got pushed, but they were working on localhost. This was fixed when I reverted. So we need to go over that branch again before I merge it back into canary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants