feat(gulp): grunt parity #1501
Merged
feat(gulp): grunt parity #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
squash the new task commits into something like |
|
Thanks @Awk34, I'll jump on these in the new few days. |
add sort function to ensure angular modules appear first in inject:js task
use template strings to turn all references to `dist/`, `client/` and `server/` into variables. update some path globs to more accurately match target files (aiming for grunt parity)
add the following tasks: * `lint:scripts:test` * `lint:scripts:serverTest` * `coverage:integration` * `coverage:pre` * `coverage:unit` * `jscs` * `lint:scripts:clientTest` * `lint:scripts:serverTest` * `mocha:coverage` * `mocha:integration` * `serve:dist` * `start:server:prod` * `test:e2e` * `webdriver_update`
ensure important files are preserved, the `.tmp` is cleaned and dot files are removed when running build task
|
Squashed and tweaked. New PR for e2e test update is #1503 |
update `test:client` to invoke Karma directly
lift mocha settings to a lazypipe for reuse and update test globs to separate unit and integration server tests
for Grunt parity, the server code should be transpiled with with the `runtime` option
filter out tests and `app.js` from the script files injected into `index.html`
use `rev.manifest` to record name changes and pass the manifest to `rev.replace` to update the appropriate files
|
New PR for mocha test updates: #1511 |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last week and a bit I've been testing and updating the gulp file (and some tests) aiming for parity with grunt. I've merged all my changes, piece by piece, into the generator and tested the results.
More testing will be required, but hopefully this will help bring gulp support closer to release.