Skip to content

feat(gulp): add Gulp support #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2015
Merged

feat(gulp): add Gulp support #1190

merged 1 commit into from
Dec 5, 2015

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Aug 19, 2015

Needs:

  • Grunt parity
    • serve (needs testing)
    • build (needs testing)
    • watch (needs testing)
    • test
  • tests

}[val];
}
}, {
type: "list",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about moving this to projectPrompts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would probably make more sense XD

@@ -82,7 +82,7 @@ var AngularFullstackGenerator = yeoman.generators.Base.extend({
this.log('# Client\n');

this.prompt([{
type: 'list',
type: "list",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be single quotes here.

@Awk34 Awk34 force-pushed the gulp branch 2 times, most recently from 76750d1 to d2325ce Compare August 24, 2015 02:56
@Awk34 Awk34 force-pushed the gulp branch 6 times, most recently from 0ce70d9 to c5c00b9 Compare September 14, 2015 00:33
@Awk34 Awk34 force-pushed the gulp branch 2 times, most recently from f2dff11 to 8c0deba Compare September 19, 2015 21:25
@Awk34 Awk34 modified the milestones: 3.1.0, 3.0.0 Nov 1, 2015
@Awk34 Awk34 mentioned this pull request Nov 29, 2015
to enable, run `yo angular-fullstack` with the `--gulp` flag
Awk34 added a commit that referenced this pull request Dec 5, 2015
add experimental Gulp support
@Awk34 Awk34 merged commit dcc8561 into canary Dec 5, 2015
@david-mohr
Copy link
Contributor

I was testing out your new gulp file and here are the changes I made to get gulp build working (yo 1.5.0):

--- gulpfile.babel.js.orig  2015-12-08 22:21:04.000000000 +1100
+++ gulpfile.babel.js   2015-12-08 22:15:37.000000000 +1100
@@ -4,6 +4,7 @@
 import _ from 'lodash';
 import del from 'del';
 import gulp from 'gulp';
+import babel from 'gulp-babel';
 import path from 'path';
 import gulpLoadPlugins from 'gulp-load-plugins';
 import http from 'http';
@@ -110,7 +111,11 @@

 let transpile = lazypipe()
     .pipe(plugins.sourcemaps.init)
-    .pipe(plugins.babel)
+    .pipe(babel, {
+      optional: [
+        'es7.classProperties'
+      ]
+    })
     .pipe(plugins.sourcemaps.write, '.');

 /********************
@@ -379,7 +384,7 @@

     let assets = plugins.useref.assets({searchPath: ['client', '.tmp']});

-    return gulp.src(paths.mainView)
+    return gulp.src(paths.client.mainView)
         .pipe(assets)
             .pipe(appFilter)
                 .pipe(plugins.addSrc.append('.tmp/templates.js'))

And in case you need them, here are my build selections.

html
sass
ngroute
bootstrap: true
UI bootstrap: true
mongoose: true
auth boilerplate: true
oAuth: none
socket.io: true
Jasmine

Thanks for all the great work!

@Awk34
Copy link
Member Author

Awk34 commented Dec 8, 2015

@david-mohr if you think there's a problem, feel free to submit a PR

@Awk34 Awk34 deleted the gulp branch December 16, 2015 04:44
@tmundt
Copy link

tmundt commented Dec 16, 2015

So, GULP is implemented?

@david-mohr
Copy link
Contributor

I'm currently working on another PR based on my testing and porting some more Grunt tasks.

@Awk34
Copy link
Member Author

Awk34 commented Dec 16, 2015

@david-mohr awesome, I look forward to it

@david-mohr
Copy link
Contributor

#1501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants