Skip to content

feat(app): implement navbar as directive #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2015
Merged

feat(app): implement navbar as directive #1042

merged 1 commit into from
Jul 8, 2015

Conversation

kingcody
Copy link
Member

@kingcody kingcody commented Jul 8, 2015

closes #457

@Awk34
Copy link
Member

Awk34 commented Jul 8, 2015

I like this, but can you change them to not be self-closing tags? The HTML spec is very particular about self-closing tags..

@kingcody
Copy link
Member Author

kingcody commented Jul 8, 2015

Absolutely

@kingcody kingcody force-pushed the feature/navbar-directive branch from 6245ace to 24171aa Compare July 8, 2015 03:48
@Awk34
Copy link
Member

Awk34 commented Jul 8, 2015

Thanks :D

Awk34 added a commit that referenced this pull request Jul 8, 2015
@Awk34
Merge pull request #1042 from kingcody/feature/navbar-directive
cc841e1 
feat(app): implement navbar as directive
@Awk34 Awk34 merged commit cc841e1 into angular-fullstack:canary Jul 8, 2015
@kingcody kingcody deleted the feature/navbar-directive branch July 8, 2015 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingcody @Awk34