-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Navbar as Directive #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In the same vain, having "sign in" and "sign up" directives could be useful to easily move this forms in another place (for instance, on the landing page). |
Or in a modal :) |
For anyone interested, I have a generated project in a test repo that contains an opinionated 'angular-fullstack navbar'. Opinions:
Also, I took a first attempt at writing test. I included a spec for the controller, service, and directive. Being those are my first 'test' with karma or jasmine, I wouldn't mind if someone pointed out any mistakes or shortcomings. |
How can I get rid of all this request:
It's polluting the console. |
Weird. They are gone. |
It's from restarting the server and not doing a fresh reload on the client side. A 'force reload' in the browser always fixes it for me. |
More specifically, it's because the socket.io endpoint has been changed and you client was 'polling' the old endpoint. Which would now simply default to serving the main index.html; hence all the the short |
Just wondering if anyone else has considered this?
I normally implement it as a directive and it seems to be fairly beneficial. Allows for easier includes and more control over its setup.
The text was updated successfully, but these errors were encountered: